Nico Huber submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved
ogp_spi: remove unused rget_io_perms()

The ogp_spi programmer does not use x86 IO Ports. Remove the dependency
to it.

Change-Id: I1f3f34e33f77159fa0cdea150e1f408ce9d943f0
Signed-off-by: Thomas Heijligen <thomas.heijligen@secunet.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/60847
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M Makefile
M ogp_spi.c
2 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/Makefile b/Makefile
index 34d517e..b351990 100644
--- a/Makefile
+++ b/Makefile
@@ -130,7 +130,6 @@
CONFIG_NIC3COM \
CONFIG_NICNATSEMI \
CONFIG_NICREALTEK \
- CONFIG_OGP_SPI \
CONFIG_RAYER_SPI \
CONFIG_SATAMV \
CONFIG_SATASII \
diff --git a/ogp_spi.c b/ogp_spi.c
index d4218d1..830cfe7 100644
--- a/ogp_spi.c
+++ b/ogp_spi.c
@@ -19,7 +19,6 @@
#include "flash.h"
#include "programmer.h"
#include "hwaccess.h"
-#include "hwaccess_x86_io.h"
#include "hwaccess_physmap.h"
#include "platform/pci.h"

@@ -142,9 +141,6 @@
}
free(type);

- if (rget_io_perms())
- return 1;
-
dev = pcidev_init(ogp_spi, PCI_BASE_ADDRESS_0);
if (!dev)
return 1;

To view, visit change 60847. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1f3f34e33f77159fa0cdea150e1f408ce9d943f0
Gerrit-Change-Number: 60847
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: merged