Attention is currently required from: Nico Huber, Angel Pons, Sergii Dmytruk.

Patch set 12:Code-Review +1

View Change

1 comment:

• File dummyflasher.c:

  • Patch Set #10, Line 264: /* XXX: should data->erase_to_zero be taken into account here? */

    It's a question to anyone who'll read the code. It just looks like a bug, but I'm not entirely sure.

    It does look like a bug to me, thanks!
    You can mark the comment as FIXME (instead of XXX).
    I would say bug fix needs to go as a separate patch, outside of this chain, unless other people disagree.

To view, visit change 59074. To unsubscribe, or for help writing mail filters, visit settings.