Attention is currently required from: Nico Huber, David Hendricks, Edward O'Callaghan.
View Change
1 comment:
Patchset:
Patch Set #6:
Even better news: now after adding includes in meson.build (my previous patchset) I discovered that unittest.h is not needed anymore in test files! So I am removing it from here. And now ninja test warnings are fixed - because there are no re-definitions anymore.
This looks like a happy ending: only one header, included in build file, no need to touch the code, all files are covered by memory checks when they are built for test environment.
I did all the testing for this last patchset, as before: nm files built for test vs for real, nm test files, running tests. Also introducing memory leak and verifying that test catches it (examples described in commit message).
To view, visit change 51243. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0c6b6b8dc17aaee28640e3fca3d1fc9f7feabf5f
Gerrit-Change-Number: 51243
Gerrit-PatchSet: 6
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz@google.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Daniel Kurtz <djkurtz@chromium.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Thomas Heijligen <src@posteo.de>
Gerrit-CC: Victor Ding <victording@chromium.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: David Hendricks <david.hendricks@gmail.com>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Comment-Date: Mon, 29 Mar 2021 23:25:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment