Attention is currently required from: Edward O'Callaghan.
Patch set 4:Code-Review +1
View Change
1 comment:
Commit Message:
Patch Set #4, Line 10: TEST=dedede with `flashrom -p internal --flash-size`.
Any other tests, e.g. reading? If the ME region is locked, you can still read the other regions. A good test would be:
flashrom -p internal --ifd -i fd -i bios -r filename.rom
This makes use of flashrom's IFD parsing code to decide which parts of the flash chip should be read.
To view, visit change 62282. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib942d0b8942fe0a991b2af0b187414818485153d
Gerrit-Change-Number: 62282
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Sam McNally <sammc@google.com>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Comment-Date: Thu, 24 Feb 2022 16:08:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment