Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.

View Change

2 comments:

• File buspirate_spi.c:

  • Patch Set #3, Line 58: unsigned char **bp_commbuf

    does this actually need double indirection?

    I think so, because the pointer can change after realloc (and the size of the buffer can also change) - but please correct me if I am wrong.

  • Patch Set #3, Line 221: unsigned char *const bp_commbuf = bp_data->bp_commbuf;

    perhaps just move this up a few lines to the functions preamble so that the branch line above can be […]

    I thought that buspirate_commbuf_grow can change the pointer, and I can have this local variable as constant pointer after buspirate_commbuf_grow.
    Both your comments have the same answer, depending on whether realloc can change the pointer?

To view, visit change 52958. To unsubscribe, or for help writing mail filters, visit settings.