Edward O'Callaghan submitted this change.
layout: Fix overlap-check routine
Fixes a regression introduced by commit 06a89d713 (layout: Introduce
layout_next()). A negation was dropped by accident which resulted in
comparisons with later, not-included regions instead of included ones.
Change-Id: I18168b9bd9a7d0fe2ba04fb091d1600f65d6dd5b
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/55997
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M layout.c
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/layout.c b/layout.c
index e688f79..36aa247 100644
--- a/layout.c
+++ b/layout.c
@@ -257,7 +257,7 @@
const struct romentry *rhs = lhs;
while ((rhs = layout_next(l, rhs))) {
- if (rhs->included)
+ if (!rhs->included)
continue;
if (lhs->start > rhs->end)
To view, visit change 55997. To unsubscribe, or for help writing mail filters, visit settings.