David Hendricks posted comments on this change.

View Change

Patch set 1:Code-Review +2

(1 comment)

• File nicintel_eeprom.c:

  • Patch Set #1, Line 106: return (device_id & 0xfff0) == 0x1530;

    As this was supposed to be a fixup!, I tried to anticipate what

    SGTM. As the file is written, your fixup! seems correct.

    If needed we can follow-up with a patch to check for other possible device IDs - perhaps by checking more raw values here or by adding an enum to nics_intel_ee[] to indicate the device's family (I210, I82580, etc) and iterating thru.

To view, visit change 21934. To unsubscribe, visit settings.