Thanks for your patch. There's one nit in the commit message
and some missed erase block commands to be added. Then it's
ready to go.

Patch set 1:Code-Review +1

View Change

2 comments:

• Commit Message:

  • Patch Set #1, Line 7: Add support for MX25U25635F.

    No full-stop at end of summary, please.

• File flashchips.c:

  • Patch Set #1, Line 8884:

    			{
    				.eraseblocks = { {4 * 1024, 8192} },
    				.block_erase = spi_block_erase_20,
    			}, {
    				.eraseblocks = { {32 * 1024, 1024} },
    				.block_erase = spi_block_erase_52,
    			}, {
    				.eraseblocks = { {64 * 1024, 512} },
    				.block_erase = spi_block_erase_d8,
    			}, {
    

    Native 4BA erase versions should also be mentioned: 21, 5c, dc

To view, visit change 33639. To unsubscribe, or for help writing mail filters, visit settings.