Nico Huber has posted comments on this change. (
https://review.coreboot.org/c/flashrom/+/33639 )
Change subject: Add support for MX25U25635F.
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Thanks for your patch. There's one nit in the commit message
and some missed erase block commands to be added. Then it's
ready to go.
https://review.coreboot.org/#/c/33639/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/33639/1//COMMIT_MSG@7
PS1, Line 7: Add support for MX25U25635F.
No full-stop at end of summary, please.
https://review.coreboot.org/#/c/33639/1/flashchips.c
File flashchips.c:
https://review.coreboot.org/#/c/33639/1/flashchips.c@8884
PS1, Line 8884: {
: .eraseblocks = { {4 * 1024, 8192} },
: .block_erase = spi_block_erase_20,
: }, {
: .eraseblocks = { {32 * 1024, 1024} },
: .block_erase = spi_block_erase_52,
: }, {
: .eraseblocks = { {64 * 1024, 512} },
: .block_erase = spi_block_erase_d8,
: }, {
Native 4BA erase versions should also be mentioned: 21, 5c, dc
--
To view, visit
https://review.coreboot.org/c/flashrom/+/33639
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5bdcd32acd1942edf65e50bce0f81c836095ee8c
Gerrit-Change-Number: 33639
Gerrit-PatchSet: 1
Gerrit-Owner: David Tomaschik <davidtomaschik(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 21 Jun 2019 12:24:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment