Richard Hughes has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35561 ) Change subject: util/getversion,meson: Add script to allow version info with Meson ...................................................................... Patch Set 4: If we can get this upstream soonish we can switch fwupd to using the upstream flashrom rather than my crazy fork with the meson changes. This means we can start compiling fwupd with flashrom enabled in distros, which I've got tons of people asking me about :) -- To view, visit https://review.coreboot.org/c/flashrom/+/35561 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I401e5638509c4a573bc0cb17ebc5fa76df9700b5 Gerrit-Change-Number: 35561 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Jacob Garber <jgarber1@ualberta.ca> Gerrit-Reviewer: Mario Limonciello <superm1@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Gerrit-Reviewer: Richard Hughes <hughsient@gmail.com> Gerrit-Reviewer: Richard Hughes <richard@hughsie.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Wed, 30 Oct 2019 14:10:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment