View Change

5 comments:

• File lspcon_i2c_spi.c:

  • Patch Set #4, Line 270: int ret = lspcon_i2c_spi_disable_all_protection(fd);

    Are you sure all of this is necessary for every command and that none of this duplicates commands that the other parts of flashrom's SPI infrastructure will generate?

  • Patch Set #4, Line 275: bit

    byte

  • Patch Set #4, Line 333: uint8_t command_byte1[] = { ROMADDR_BYTE1, (offset >> 8) & 0xff };

    Given ROMADDR_BYTE1 and ROMADDR_BYTE2 are adjacent, can this not be done in a single write? Otherwise, this should use lspcon_i2c_spi_write_register.

  • Patch Set #4, Line 406: 256

    Are you sure about these?

  • Patch Set #4, Line 431: ()

    (void)

To view, visit change 39687. To unsubscribe, or for help writing mail filters, visit settings.