Attention is currently required from: Felix Singer, Angel Pons, Light.

View Change

1 comment:

• File ich_descriptors.c:

  • Patch Set #7, Line 1364: int ret = read_ich_descriptors_from_dump(dump, len, &cs, &desc);

    As far as I can see, all fields are getting filled before returning 0.

    Hmmm, that matches what I suspected. Doesn't say we are correct, though ;)

    My concern here is that scan-build might only complain because it isn't
    smart enough to see this. And if that's the case and we zero initialize the
    struct now, there wouldn't be anything to see if read_ich_descriptors_from_dump()
    would break in the future. So a potential, future, smarter scan-build or similar
    tool might be able to warn us, but only if we don't initialize the struct.

To view, visit change 62763. To unsubscribe, or for help writing mail filters, visit settings.