Attention is currently required from: Anastasia Klimchuk, Matti Finder.
View Change
1 comment:
File include/rpmc.h:
Patch Set #1, Line 37: uint8_t status;
It looks like you use status values in the CLI and 0x80 always indicates success, but that's not a value I would expect to indicate success. Can you add a little documentation here and perhaps also explain better what the function return values mean (even if it's just referring to an explanation attached to this field)?
To view, visit change 84934. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I6ab3d0446e9fd674b20550fdbfaf499b8d4a9b38
Gerrit-Change-Number: 84934
Gerrit-PatchSet: 1
Gerrit-Owner: Matti Finder <matti.finder@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Matti Finder <matti.finder@gmail.com>
Gerrit-Comment-Date: Wed, 30 Oct 2024 22:35:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No