View Change

2 comments:

• File flashchips.c:

  • Patch Set #5, Line 10628: 1E", /* ..1E = 1.8V, uniform 64KB/4KB blocks/sectors */

    This is not quite right - The suffix on 512mbit parts should be 1G for 1.8V, uniform sectors. […]

    This is fixed later in the patch stack: https://review.coreboot.org/c/flashrom/+/34520/4 as I noticed the error later in my development process. We could rebase/reorder/squash it if you want, but this has been wrong for so long and it doesn't impact any functional behavior that I just left it as is and let the commits reflect the changes atomically.

  • Patch Set #5, Line 10631: 1E

    Not your fault, but this should be 1G.

    See above.

To view, visit change 34491. To unsubscribe, or for help writing mail filters, visit settings.