View Change
2 comments:
File flashchips.c:
Patch Set #5, Line 10628: 1E", /* ..1E = 1.8V, uniform 64KB/4KB blocks/sectors */
This is not quite right - The suffix on 512mbit parts should be 1G for 1.8V, uniform sectors. […]
This is fixed later in the patch stack: https://review.coreboot.org/c/flashrom/+/34520/4 as I noticed the error later in my development process. We could rebase/reorder/squash it if you want, but this has been wrong for so long and it doesn't impact any functional behavior that I just left it as is and let the commits reflect the changes atomically.
Patch Set #5, Line 10631: 1E
Not your fault, but this should be 1G.
See above.
To view, visit change 34491. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I85630e4f6c0aa3b261f9871b7d363dad278b997e
Gerrit-Change-Number: 34491
Gerrit-PatchSet: 5
Gerrit-Owner: Jacob Creedon <jcreedon@google.com>
Gerrit-Assignee: Jacob Creedon <jcreedon@google.com>
Gerrit-Reviewer: Alan Green <avg@google.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Jacob Creedon <jcreedon@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Comment-Date: Thu, 03 Oct 2019 15:05:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Hendricks <david.hendricks@gmail.com>
Gerrit-MessageType: comment