Jacob Creedon has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34491 )
Change subject: flashchips: Add missing N25Q/MT25Q 1.8v variants ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/flashrom/+/34491/5/flashchips.c File flashchips.c:
https://review.coreboot.org/c/flashrom/+/34491/5/flashchips.c@10628 PS5, Line 10628: 1E", /* ..1E = 1.8V, uniform 64KB/4KB blocks/sectors */
This is not quite right - The suffix on 512mbit parts should be 1G for 1.8V, uniform sectors. […]
This is fixed later in the patch stack: https://review.coreboot.org/c/flashrom/+/34520/4 as I noticed the error later in my development process. We could rebase/reorder/squash it if you want, but this has been wrong for so long and it doesn't impact any functional behavior that I just left it as is and let the commits reflect the changes atomically.
https://review.coreboot.org/c/flashrom/+/34491/5/flashchips.c@10631 PS5, Line 10631: 1E
Not your fault, but this should be 1G.
See above.