Attention is currently required from: Angel Pons, qianfan.

8 comments:

File ch347t_spi.c:
- Patch Set #2, Line 34: CH347_CMD_SPI_CONTROL,
  Yes
  Done
File ch347t_spi.c:
- Patch Set #3, Line 119: SPI_NSS_HARD
  OK, I will change it to SPI_NSS_SOFT, as same as the vendor drivers.
  Done
- Patch Set #3, Line 330: ch347t_spi_spi_send_command
  The two "spi"s are redundant
  Done
- Patch Set #3, Line 367:
```
	libusb_release_interface(handle, 0);
	libusb_attach_kernel_driver(handle, 0);
```
  Interface 2, see comment in `ch347t_spi_init`
  Done
- Patch Set #3, Line 420: 0
  Got it. I will make a change.
  Done
- Patch Set #3, Line 425: 0
  Interface 2
  Done
- Patch Set #3, Line 442:
```
release_interface:
	libusb_release_interface(handle, 0);
close_handle:
	libusb_attach_kernel_driver(handle, 0);
```
  Interface 2
  Done
File ch347t_spi.c:
- Patch Set #5, Line 169:
```
if (n > CH347_MAX_DATA_WRITE)
			n = CH347_MAX_DATA_WRITE;
```
  Oh wait, this is chunking the transfers, right? It's a bit confusing because the chunk size goes thr […]
  Yes, I believe this code is for splitting up transfers into smaller transfers. I did basically the same thing in my code. Looks like there is a `min()` function in `helpers.c`, which is declared in the `flash.h` header file (which is already included)

To view, visit change 70529. To unsubscribe, or for help writing mail filters, visit settings.