Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk.

View Change

1 comment:

• File dummyflasher.c:

  • Patch Set #34, Line 169: assert

    Just wanted to check whether everyone is fine with `assert` in the code? It is not often used in fla […]

    `assert` is used only once in flashrom beside the tests. I would prefer not to use it. But I don't think we have a rule for it.
    How about:
        #define STATUS1_RO_BITMASK SPI_SW_WIP
        #define STATUS2_RO_BITMASK 0
        #define STATUS3_RO_BITMASK 0
    or
        const uint8_t status1_ro_bitmask = SPI_SW_WIP;
        const uint8_t status2_ro_bitmask = 0;
        const uint8_t status3_ro_bitmask = 0;
    ?

    Where is the benefit from a function over this?

To view, visit change 59072. To unsubscribe, or for help writing mail filters, visit settings.