Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Peter Marheine.

View Change

9 comments:

• Commit Message:

  • Patch Set #6, Line 10: FFI

    What's this?

    Done

  • Patch Set #6, Line 16: and after the change.

    And what's the result of the test?

    Done

• File include/libflashrom.h:

  • Patch Set #6, Line 65: file

    a file […]

    Done

  • Patch Set #6, Line 262: short

    small

    Done

  • Patch Set #6, Line 356: buffer

    a buffer

    Done

  • Patch Set #6, Line 372: another

    I'd use `a` to be more precise, as `flashrom_layout_new()` returns layouts with no regions.

    I am happy to make these edits, I'm just checking that you know I am moving these lines from one place to another.

  • Patch Set #6, Line 398:

     * @param start  The start address to be written.
     * @param len    The length of the region to be written.
    

    Maybe @param[out] ?

    Done

  • Patch Set #6, Line 416: he

    I'd avoid using personal pronouns in documentation, the caller isn't necessarily a "he". How about: […]

    Done

  • Patch Set #6, Line 463: [out]

    Why is this an out parameter?

    Done

To view, visit change 63903. To unsubscribe, or for help writing mail filters, visit settings.