Attention is currently required from: Edward O'Callaghan, Angel Pons, Nikolai Artemiev.
Patch set 1:Code-Review +1
View Change
2 comments:
File flashrom.8.tmpl:
Patch Set #1, Line 319: Currently supported are
This is of course not for this patch, but is there any reason programmers are not in alphabetical order? :)
Patch Set #1, Line 1154: custom_rst=(true,false)
It might be a little confusing, because description talks about delay in ms, but parameter is boolean. I understand the parameter is what it is, but maybe a bit more clarity, what does it mean when it is set "true" vs "false"?
custom_rst=true -> does it mean 10ms?
custom_rst=false -> does it mean 1-3ms?
no parameter -> does it mean 1-3ms?
To view, visit change 62768. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I186920006bdfcc7a9f89542f84b452dfc72b18e4
Gerrit-Change-Number: 62768
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Fri, 18 Mar 2022 00:38:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment