Attention is currently required from: Michał Żygowski, Jonathan Zhang, David Hendricks, Angel Pons.
View Change
1 comment:
File ich_descriptors.c:
Patch Set #1, Line 968:
if (content->ICCRIBA != 0x34)
msg_pwarn("Unknown flash descriptor, assuming 300 series compatibility.\n");
Regardless, this is not worth splitting hairs so I've reverted back to using msg_pwarn() since you seem to prefer it that way.
It's not about splitting hairs or preferences. You didn't mention this change
in the commit message so I thought you did it by accident. Please just do such
changes in separate commits. Then intentions are obvious and, as Angel has
shown, can be discussed.
To view, visit change 57793. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ica49477492876810a6fa212768b1ab9e8c12001f
Gerrit-Change-Number: 57793
Gerrit-PatchSet: 4
Gerrit-Owner: David Hendricks
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Attention: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Attention: David Hendricks
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Thu, 30 Sep 2021 15:17:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: David Hendricks
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment