Attention is currently required from: Edward O'Callaghan, Sergii Dmytruk.

View Change

1 comment:

• File flashrom.c:

  • Patch Set #13, Line 1931: restore_flash_wp(flash, initial_wp_cfg);

    Indirectly calling `flashrom_wp_write_cfg` is intentional here? I guess it won't hurt, just looks w […]

    Good point, I hadn't looked at this CL in a while and I thought we needed to restore in this case since the restore function won't be called if registration fails.

    But this all happens before we disable flash protection in `unlock_flash_wp()` so we just need to free the reference to `initial_wp_cfg` like you said in your first comment.

To view, visit change 69517. To unsubscribe, or for help writing mail filters, visit settings.