Attention is currently required from: Angel Pons, Light, Anastasia Klimchuk.

View Change

1 comment:

• File ich_descriptors.c:

  • Patch Set #6, Line 507: assert(j >= 12);

    I am not sure, are we using assert in code? I am wondering what other people think. […]

    I had a similar thought on the patch around `writeprotect_ranges.c`. Such
    an assertion would help scan-build. Not sure if it helps humans :)

    In this instance, maybe just make it explicit:

      for (j = 12; j < num_regions; ++j)

    ?

    If we'd want `assert()` only for function contracts, we could also make
    exceptions and comment, e.g.

      assert(j >= 12); /* to help scan-build */

To view, visit change 62764. To unsubscribe, or for help writing mail filters, visit settings.