Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

3 comments:

• File flashrom.c:

  • Patch Set #4, Line 918: Get

    You can leave "return" in this case, I think return sounds good here.

    Done

  • Patch Set #4, Line 924: char *ret, *ptr;

    I am going to ask silly question: why do you need both? […]

    Hmm... `strcat_realloc()` may return NULL. In such case `ret = strcat_realloc(ret, ...);` we will lose the pointer to the allocated space => memory leak

  • Patch Set #4, Line 938:

    	if (bustype == BUS_NONSPI)
    		return strdup("Non-SPI");
    	if (bustype == BUS_NONE)
    		return strdup(bustypes[bustype]);
    

    These first two cases (BUS_NONSPI and BUS_NONE) are specially handled in the code, I understand why, […]

    You're definitely right, your suggestion will simplify everything, thanks! Done.

To view, visit change 73039. To unsubscribe, or for help writing mail filters, visit settings.