Edward O'Callaghan submitted this change.
spi_master: Add default write_aai function to masters that have none
write_aai is required to register a spi master, if it is not set in
spi_master struct then register_spi_master returns ERROR_FLASHROM_BUG.
Masters in this patch did not have it set in the struct, and
register_spi_master always returned an error for them. However return
value of register_spi_master was ignored, so this was hard to notice.
Next patch in the chain checks return value of register_spi_master.
BUG=b:185191942
TEST=builds and ninja test
Change-Id: I712e74e11244e1f0ab8d8e245fcd5207ce211219
Signed-off-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/56102
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
---
M ene_lpc.c
M mec1308.c
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/ene_lpc.c b/ene_lpc.c
index b30eee6..23ba12b 100644
--- a/ene_lpc.c
+++ b/ene_lpc.c
@@ -511,6 +511,7 @@
.multicommand = default_spi_send_multicommand,
.read = default_spi_read,
.write_256 = default_spi_write_256,
+ .write_aai = default_spi_write_aai,
};
static int check_params(void)
diff --git a/mec1308.c b/mec1308.c
index 295bffb..c085ff2 100644
--- a/mec1308.c
+++ b/mec1308.c
@@ -404,6 +404,7 @@
.multicommand = default_spi_send_multicommand,
.read = default_spi_read,
.write_256 = default_spi_write_256,
+ .write_aai = default_spi_write_aai,
};
static int check_params(void)
To view, visit change 56102. To unsubscribe, or for help writing mail filters, visit settings.