Looks like your editor is putting spaces everywhere

View Change

10 comments:

• File raiden_debug_spi.c:

  • Patch Set #3, Line 307:

    Can use tabs here

  • Patch Set #3, Line 334:

    Maybe use a tab instead of eight spaces

  • Patch Set #3, Line 352: ctx_data->out_ep,

    This looks pretty weird. Also, it could use tabs

  • Patch Set #3, Line 372:

    there are spaces

  • Patch Set #3, Line 382:

    Can use tabs here

  • Patch Set #3, Line 394:

    Can use tabs here

  • Patch Set #3, Line 431:

    Can use tabs here

  • Patch Set #3, Line 518:

    /* We were successful at performing the SPI transfer. */
    				return status;
    

    This can be moved at line 498:

     if (status == 0) {
     	if (read_ctx.receive_size != read_ctx.receive_index) {
     		status = USB_SPI_HOST_RX_READ_FAILURE;

     	} else {
     		/* We were successful at performing the SPI transfer. */
     		return status;
     	}
     }

    Then, the "if (status) {" at line 501 can go away

  • Patch Set #3, Line 624:

    moar spaces that should be tabs

  • Patch Set #3, Line 777:

    use tabs

To view, visit change 41532. To unsubscribe, or for help writing mail filters, visit settings.