Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41532 ) Change subject: raiden_debug_spi.c: Refactor to support multiple protocols ...................................................................... Patch Set 3: (10 comments) Looks like your editor is putting spaces everywhere https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c File raiden_debug_spi.c: https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@307 PS3, Line 307: Can use tabs here https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@334 PS3, Line 334: Maybe use a tab instead of eight spaces https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@352 PS3, Line 352: ctx_data->out_ep, This looks pretty weird. Also, it could use tabs https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@372 PS3, Line 372: there are spaces https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@382 PS3, Line 382: Can use tabs here https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@394 PS3, Line 394: Can use tabs here https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@431 PS3, Line 431: Can use tabs here https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@518 PS3, Line 518: /* We were successful at performing the SPI transfer. */ : return status; This can be moved at line 498: if (status == 0) { if (read_ctx.receive_size != read_ctx.receive_index) { status = USB_SPI_HOST_RX_READ_FAILURE; } else { /* We were successful at performing the SPI transfer. */ return status; } } Then, the "if (status) {" at line 501 can go away https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@624 PS3, Line 624: moar spaces that should be tabs https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@777 PS3, Line 777: use tabs -- To view, visit https://review.coreboot.org/c/flashrom/+/41532 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id404af14e55fa0884e29f28880206aaad4deba66 Gerrit-Change-Number: 41532 Gerrit-PatchSet: 3 Gerrit-Owner: Brian Nemec <bnemec@google.com> Gerrit-Reviewer: Brian Nemec <bnemec@chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-Comment-Date: Tue, 19 May 2020 16:21:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment