Attention is currently required from: Felix Singer, Michał Żygowski, Paul Menzel, Angel Pons, Arthur Heymans, Michael Niewöhner, Sergii Dmytruk.

View Change

1 comment:

• File board_enable.c:

  • Patch Set #2, Line 2339: return 0;

    I hope we can reduce the dependencies. For a start: there should
    be a trade-off how much code is re-used. If the goal is to re-use
    board_enable, we should be able (with little changes to existing
    code) to skip all the regular preparations to actually access the
    flash chip (that draw in most of the dependencies).

    I only had a very quick look. What I imagine might roughly look
    like this:

      dmi_init();
      pci_init_common();

      if (!board_match_...())
          bail out

      tool-specific code

    Will try to experiment with that soon. If nobody beats me to it.

    Even pcidev.c depends on programmer, because it uses register_shutdown() and thus brings in half of flashrom.

    That would be one of the little changes, e.g. make calling
    register_shutdown() optional, then the tool would have to call
    pcidev_shutdown() directly.

To view, visit change 56023. To unsubscribe, or for help writing mail filters, visit settings.