Attention is currently required from: Anastasia Klimchuk.

View Change

4 comments:

• File doc/classic_cli_manpage.rst:

  • Patch Set #2, Line 619: **Frequency**

    I'd document that the range is [1Hz, 8000Mhz] and there is no delay by default.

  • Patch Set #2, Line 620: emulated

    nit:
    ```suggestion
    	Frequency can be specified in ``Hz`` (default), ``KHz``, or ``MHz`` (not case sensitive).
    ```

  • Patch Set #2, Line 624: The delay is calculated based on the assumption that we only work with bytes and transfer at 1 bit/Hz::

    ```suggestion
    	The delay of an SPI command is proportional to the number of bits send over SPI bus in both directions and is calculated based on the assumption that we transfer at 1 bit/Hz::
    ```

• File dummyflasher.c:

  • Patch Set #2, Line 1169: if (freq == 0) {

    A similar check could be added for an upper bound. It's quite confusing to get a zero delay all of a sudden.

To view, visit change 84423. To unsubscribe, or for help writing mail filters, visit settings.