Attention is currently required from: Thomas Heijligen.
View Change
1 comment:
Patchset:
Patch Set #6:
We can go on from this and remove fallback_(un)map because this it is an empty function
true although it maybe useful to have a stub symbol like that for tracing purposes. I have no strong feelings in either direction.
One take away from these patches is that the same theme could be repeated for `default_spi_probe_opcode` and similar kinds of fields where the null checks are done at runtime in parallel.c/spi.c and opaque.c
To view, visit change 66677. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic02092ce23c5b3233aad38343b888e3fa7e5bcf9
Gerrit-Change-Number: 66677
Gerrit-PatchSet: 7
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Comment-Date: Fri, 09 Sep 2022 12:52:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen <src@posteo.de>
Gerrit-MessageType: comment