Anastasia Klimchuk submitted this change.

View Change

Approvals: Dmitry Zhadinets: Looks good to me, but someone else must approve build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved
libflashrom: Set maximum log level SPEW by default

This log level is the maximum level that will trigger the log
callback. By default log callback should be triggered for all
messages, and then client can decide whether they want to lower
the level.

This also keeps the same behaviour for existing clients of
libflashrom, the same as it was before introducing the ability
to set max log level in log callback API.

Follow up on
commit 4e334c4f79da2b621917da8f47dcf33bb2c0cfbc

Change-Id: Id063c31e685c930b9f5632c7b86ffac6fe477fd5
Signed-off-by: Anastasia Klimchuk <aklm@flashrom.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/87180
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Dmitry Zhadinets <dzhadinets@gmail.com>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
---
M libflashrom.c
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libflashrom.c b/libflashrom.c
index a9aff50..888ca05 100644
--- a/libflashrom.c
+++ b/libflashrom.c
@@ -34,7 +34,7 @@
static flashrom_log_callback *global_log_callback = NULL;
static flashrom_log_callback_v2 *global_log_callback_v2 = NULL;
static void *global_log_user_data = NULL;
-static enum flashrom_log_level global_log_level = FLASHROM_MSG_INFO;
+static enum flashrom_log_level global_log_level = FLASHROM_MSG_SPEW;

int flashrom_init(const int perform_selfcheck)
{

To view, visit change 87180. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Id063c31e685c930b9f5632c7b86ffac6fe477fd5
Gerrit-Change-Number: 87180
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Dmitry Zhadinets <dzhadinets@gmail.com>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>