Attention is currently required from: Felix Singer.
Patch set 15:Code-Review +2
View Change
1 comment:
File pony_spi.c:
Patch Set #15, Line 191: data->negate_miso = false;
Usually I align these things so that true/false have more contrast:
```
data->negate_cs = true;
data->negate_sck = false;
data->negate_mosi = false;
data->negate_miso = false;
```
To view, visit change 66875. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iecd98c391a74794647caeeb2715707ccd681463c
Gerrit-Change-Number: 66875
Gerrit-PatchSet: 15
Gerrit-Owner: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Comment-Date: Wed, 07 Sep 2022 10:14:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment