Attention is currently required from: Victor Ding.
View Change
1 comment:
File Makefile:
Patch Set #6, Line 187: endif
The code was ported from Chromium's flashrom fork, I don't think it has ever been verified on DOS; t […]
It doesn't make sense to artificially limit support. Plus, the programmer lacks any sort of compatibility list to ensure it isn't used on an unknown system by accident. Yes, other programmers also have this issue.
To view, visit change 44541. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2d51b4bdc0b38b6e488e71b9e774eb6232a2069e
Gerrit-Change-Number: 44541
Gerrit-PatchSet: 6
Gerrit-Owner: Victor Ding <victording@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Victor Ding <victording@google.com>
Gerrit-Comment-Date: Mon, 28 Jun 2021 09:39:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Victor Ding <victording@google.com>
Gerrit-MessageType: comment