IMHO, taking shortcuts is one of the problems that made flashrom
less
maintainable and makes merging of new patches much harder. Usually,
the time you spend to do something right from the beginning pays
off
later. If you want, I can take this one commit over and you'd only
have to rebase the others on it.

IMHO, taking shortcuts is one of the problems that made flashrom
less
maintainable and makes merging of new patches much harder. Usually,
the time you spend to do something right from the beginning pays
off
later. If you want, I can take this one commit over and you'd only
have to rebase the others on it.

Thank you very much, that would be very helpful (and hopefully benefit the future chips as well). Meanwhile I will try to bring other KB9012 commits into a good condition

View Change

To view, visit change 23262. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89a53ccaef2791a2ac32904d7ab813da7478a6f0
Gerrit-Change-Number: 23262
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Kocialkowski <contact@paulk.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sat, 03 Feb 2018 12:27:11 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No