Attention is currently required from: Angel Pons, Anastasia Klimchuk.
View Change
1 comment:
Commit Message:
Patch Set #3, Line 22:
AFAICS, the current implementation tests a particular path of the
init procedure. There are two ways for it to succeed: reading the
buffer size from sysfs and the fallback to getpagesize().
It would be nice to mention the tested path in the commit message
and as a comment in linux_spi_init_and_shutdown_test_success().
To view, visit change 52498. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4911fbb6f04371283f0e62d2196bdd691a227584
Gerrit-Change-Number: 52498
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Thu, 22 Apr 2021 11:59:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment