Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev, Anastasia Klimchuk.
View Change
1 comment:
Patchset:
Patch Set #2:
How else can we check if the region is write protected from this erase path. […]
Currently we are checking for wp from region->write_prot but that only works for BUS_PROG. For all else we attempt to erase and the failure of the erase function tells us something is wrong. This makes it difficult to figure out the reason for failure especially if its because the region is wp since the code already does the checks for writable (the first case) before attempting to erase. I feel there should be get_region for all programmers, if possible :)
To view, visit change 74872. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie13e43b18b20dbb956b569e554953a19eb32ea22
Gerrit-Change-Number: 74872
Gerrit-PatchSet: 3
Gerrit-Owner: Aarya <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Tue, 02 May 2023 17:51:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Aarya <aarya.chaumal@gmail.com>
Gerrit-MessageType: comment