Attention is currently required from: Anastasia Klimchuk, Alexander Goncharov.

View Change

1 comment:

• File ch341a_spi.c:

  • Patch Set #3, Line 80:

    	struct libusb_transfer *transfer_out;
    	struct libusb_transfer *transfer_ins[USB_IN_TRANSFERS];
    
    	/* Accumulate delays to be plucked between CS deassertion and CS assertions. */
    	unsigned int stored_delay_us;
    
    	struct libusb_device_handle *handle;
    

    Done

    I recommend putting the handle at the start of the struct so that overflows in the above transfer buffers should they happen do not overflow into execution flow memory where function pointers exist.

To view, visit change 72807. To unsubscribe, or for help writing mail filters, visit settings.