Attention is currently required from: Thomas Heijligen, Edward O'Callaghan.

View Change

9 comments:

• Commit Message:

  • Patch Set #7, Line 12: get mandetory

    get mandetory -> gets mandatory

  • Patch Set #7, Line 20: get's selectet

    get's selectet -> gets selected

  • Patch Set #7, Line 21: determin

    determin -> determine

• Patchset:

  • Patch Set #7:

    Thomas this is really really awesome!

• File meson.build:

  • Patch Set #7, Line 109: get edded

    does it mean "gets added"?

  • Patch Set #7, Line 212:

    	'internal' : {
    		'systems' : systems_raw_hwaccess + ['linux'],
    		'cpu_families' : (host_machine.system() == 'linux' ? [host_machine.cpu_family()] : ['x86', 'x86_64']),
    		'deps'    : [ libpci ],
    		'groups'  : [ ],
    		'srcs'    : (host_machine.cpu_family() in ['x86', 'x86_64'] ? files(
    			'processor_enable.c',
    			'chipset_enable.c',
    			'board_enable.c',
    			'cbtable.c',
    			'internal.c',
    			'it87spi.c',
    			'it85spi.c',
    			'sb600spi.c',
    			'amd_imc.c',
    			'wbsio_spi.c',
    			'mcp6x_spi.c',
    			'ichspi.c',
    			'dmi.c',
    			'pcidev.c',
    		) : files(
    			'board_enable.c',
    			'cbtable.c',
    			'chipset_enable.c',
    			'internal.c',
    			'processor_enable.c',
    			'pcidev.c',
    		)),
    		'flags' : [
    			'-DCONFIG_INTERNAL=1',
    			'-DCONFIG_INTERNAL_DMI=' + (get_option('use_internal_dmi') ? '1' : '0'),
    		]
    	},
    

    I remember there was a conversation about internal, that it needs a refactoring to make the array idea work. Is it still true?

  • Patch Set #7, Line 484: srcs += 'bitbang_spi.c'

    oh... was it missing all the time?

• File meson_options.txt:

  • Patch Set #7, Line 6: choices

    Just checking, this is an array, so it allows having combinations like
    all+auto+programmer1+programmer2+...
    Is there any concerns? The code looks like it would work fine with any combination, which is great!

  • Patch Set #7, Line 9:

    'atahpt', 'atapromise', 'buspirate_spi', 'ch341a_spi', 'dediprog', 'developerbox_spi',
    	'digilent_spi', 'jlink_spi', 'drkaiser', 'dummy', 'ft2232_spi', 'gfxnvidia', 'raiden_debug_spi',
    	'internal', 'it8212', 'linux_mtd', 'linux_spi', 'mstarddc_spi', 'nic3com', 'nicintel_eeprom',
    	'nicintel', 'nicintel_spi', 'nicnatsemi', 'nicrealtek', 'ogp_spi', 'pickit2_spi', 'pony_spi',
    	'rayer_spi', 'satamv', 'satasii', 'serprog', 'usbblaster_spi', 'stlinkv3_spi',
    	'lspcon_i2c_spi', 'mediatek_i2c_spi', 'realtek_mst_i2c_spi',
    

    For the list of individual programmers, do you think maybe we can order them alphabetically? It wasn't ordered before, but I don't know why.

To view, visit change 63724. To unsubscribe, or for help writing mail filters, visit settings.