8 comments:

Commit Message:
- Patch Set #3, Line 7: lspcon_i2c_spi.c: Add support for the i2c-controlled SPI master in PS175/176.
  You can move this down into the body and have a shorter summary line: […]
  Done
File lspcon_i2c_spi.c:
- Patch Set #3, Line 33: #define FUNCTION_ERR -1
  use flashrom enum of native error codes.
  Done
- Patch Set #3, Line 80:
```
uint8_t data_size;
	const uint8_t *data;
```
  swap these two for readability?
  Done
- Patch Set #3, Line 105: if (!flash || !flash->mst || !flash->mst->spi.data) {
  under what conditions is this true in practice?
  Most likely this won't be true, but this prevent some cases that `register_lspcon_i2c_spi_master` might not register customized master with proper data.
- Patch Set #3, Line 110: (const struct lspcon_i2c_spi_data *)flash->mst->spi.data
  case to an intermediate and then extract.
  Done
- Patch Set #3, Line 418: int fd = ((struct lspcon_i2c_spi_data *)data)->fd;
  cast it then extract the value.
  Done
- Patch Set #3, Line 487:
```
	struct lspcon_i2c_spi_data data = { fd };
	void *data_ptr = calloc(1, sizeof(data));
```
  just calloc the heap and set the member, avoid the memcpy(). […]
  Done
- Patch Set #3, Line 500:
  trim \n
  I am pretty sure there is no new line at the end, is that just a display issue?

To view, visit change 39687. To unsubscribe, or for help writing mail filters, visit settings.