Thank you everyone for your comments!

View Change

2 comments:

• File it85spi.c:

  • Patch Set #5, Line 77:

            unsigned int shm_io_base;
            unsigned char *ce_high, *ce_low;
            int it85xx_scratch_rom_reenter;
    
    

    thanks for picking this up.

    Done, I set up editor so that tab is tab and it's 8 chars.
    I am interested to improve the linter! (but not in this CL).

  • Patch Set #5, Line 321: spi_master_it85xx.data = data;

    Removing "static globals of any kind" is not a goal in and of itself. […]

    Yes, there will be more patches [coming soon] to add unit tests, and removing global state is a big thing that unblocks unit testing.

To view, visit change 47655. To unsubscribe, or for help writing mail filters, visit settings.