View Change

2 comments:

• File layout.c:

  • Patch Set #8, Line 140: msg_gerr("Out of memory");

    Missing \n

    I was advised by my reviewers to adjust new code to CB:69472 and so I opened that patch and looked into layout.c https://review.coreboot.org/c/flashrom/+/69472/3/layout.c
    and did the same for my code.

    Now after your question, I looked at that patch again, it actually has two files: layout.c and flashrom.c. The former has no `\n`, the latter has `\n` :D

    I will create another patch to make layout.c out of memory error messages consistent.

  • Patch Set #8, Line 146: msg_gerr("Out of memory");

    Missing \n

    Same as above, I will close this comment and keep another thread.

To view, visit change 70006. To unsubscribe, or for help writing mail filters, visit settings.