29 May
2018
29 May
'18
1:16 a.m.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/26576 )
Change subject: flashchips: Add ATMEL AT25SL128A ......................................................................
Patch Set 1:
(1 comment)
One small nit, otherwise looks good. Thanks!
https://review.coreboot.org/#/c/26576/1/flashchips.c File flashchips.c:
https://review.coreboot.org/#/c/26576/1/flashchips.c@2287 PS1, Line 2287: 1650, 1950 Voltage tolerance is 1.7-2.0 according to the datasheet, so this should be {1700, 2000}.
--
To view, visit https://review.coreboot.org/26576
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60c433ffe9e34663c2cfc608b8b76943cd92a8ba
Gerrit-Change-Number: 26576
Gerrit-PatchSet: 1
Gerrit-Owner: Hal Martin hal.martin+coreboot@gmail.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: David Hendricks david.hendricks@gmail.com
Gerrit-Comment-Date: Mon, 28 May 2018 23:16:38 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No