Attention is currently required from: Nico Huber, Angel Pons.
View Change
1 comment:
Patchset:
Patch Set #1:
Sorry, I'm not convinced. This looks like a workaround for something only downstream uses. […]
Losing FEATURE_QPI definitely isn't ideal. I'm looking into whether the 'B' chips also support QPI; if they do does then I think merging would be ok, but please let me know if there are other issues.
Having a way to ignore a list of chips would be useful too, though I think there is still benefit to merging chips that actually are identical, both for downstream and upstream users.
To view, visit change 52883. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I688f2e15aef61afbec728a9a81094bee56d6fbfa
Gerrit-Change-Number: 52883
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Sat, 08 May 2021 05:07:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Nikolai Artemiev <nartemiev@google.com>
Gerrit-MessageType: comment