Attention is currently required from: Brian Norris, Peter Marheine, Thomas Heijligen.
View Change
1 comment:
File tests/udelay.c:
Patch Set #9, Line 41: This test could fail spuriously on a heavily-loaded system
> do you think it would be reasonable to maintain this assertion as-is provided we ensure the tested […]
Brian, you have good points. Thank you for sharing your valuable experience!
I had this thought about guarding against infinite loop (if this is a useful thing?), but for this any large upper bound will do, can be 100x or anything
Peter maybe I will leave it to you to decide. I am so happy that you added a test!
To view, visit change 81545. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I7ac5450d194a475143698d65d64d8bcd2fd25e3f
Gerrit-Change-Number: 81545
Gerrit-PatchSet: 9
Gerrit-Owner: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Brian Norris <briannorris@chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Brian Norris <briannorris@chromium.org>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Comment-Date: Tue, 16 Apr 2024 12:15:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Brian Norris <briannorris@chromium.org>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Comment-In-Reply-To: Peter Marheine <pmarheine@chromium.org>
Gerrit-MessageType: comment