Attention is currently required from: Anastasia Klimchuk, David Wu, Hsuan-ting Chen, Kapil Porwal, Maximilian Brune, Subrata Banik, Tyler Wang.
Patch set 11:Code-Review +2
View Change
2 comments:
File flashchips.c:
Patch Set #9, Line 6559: FEATURE_WRSR_EXT2
Hi Hsuan-ting, thank you for helping collect and share these information! […]
`FEATURE_WRSR_EXT` is correct for GD25LQ255E, the sequence diagram in figure 10 on page 27 of the datasheet shows that both registers can be written together.
Patch Set #9, Line 6595: 1695, 1950
Dear reviewers, […]
This should match the datasheet, i.e. `{1650, 2000}`.
To view, visit change 79088. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I0d780255ed6772f4aa406584acf071a7ddd6da47
Gerrit-Change-Number: 79088
Gerrit-PatchSet: 11
Gerrit-Owner: Tyler Wang <tyler.wang@quanta.corp-partner.google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: David Wu <david_wu@quanta.corp-partner.google.com>
Gerrit-Reviewer: Hsuan-ting Chen <roccochen@google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan@9elements.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune@9elements.com>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: David Wu <david_wu@quanta.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: Hsuan-ting Chen <roccochen@google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal@google.com>
Gerrit-Attention: Tyler Wang <tyler.wang@quanta.corp-partner.google.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune@9elements.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Wed, 03 Jan 2024 01:05:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hsuan-ting Chen <roccochen@google.com>
Comment-In-Reply-To: Tyler Wang <tyler.wang@quanta.corp-partner.google.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment