Attention is currently required from: Sam McNally, Edward O'Callaghan, Anastasia Klimchuk.

Patch set 4:Code-Review +1

View Change

8 comments:

• Commit Message:

  • Patch Set #2, Line 7: tests/: Add subregion alignment unit-test

    Done

    What does non-aligned mean? The commit message can match the test name

• File tests/chip.c:

  • Patch Set #2, Line 469: * {MOCK_CHIP_SUBREGION_CONTENTS} [..] {MOCK_CHIP_SUBREGION_CONTENTS}.

    Done

    I dont understand this:
    `{MOCK_CHIP_SUBREGION_CONTENTS} [..] {MOCK_CHIP_SUBREGION_CONTENTS}`

• File tests/chip.c:

  • Patch Set #4, Line 443: /* FIXME: MOCK_CHIP_CONTENT is buggy within setup_chip, it should also

    should this comment be here? if its buggy does the test work? what bug?

  • Patch Set #4, Line 447: #define MOCK_CHIP_SUBREGION_CONTENTS 0xCC

    CC is now the default setting of the chip, probably doesnt matter

  • Patch Set #4, Line 457: /* Expect to verify the write completed successfuly within the region. */

    is the presence of these flags important for catching the bug?

    If so, document why. If not, remove them.

  • Patch Set #4, Line 469: * Create subregion smaller than erase granularity of chip.

    subregion -> region whole file replace please

  • Patch Set #4, Line 498: /* .. */

    remove

  • Patch Set #4, Line 500: /* Expect a verification pass that content within the region however

    this doesnt make sense

To view, visit change 71659. To unsubscribe, or for help writing mail filters, visit settings.