Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
3 comments:
File pickit2_spi.c:
Do we need this struct? I guess it would make it easier to extend in the
future, but this seems hard to predict. We could also pass the libusb handle
directly as `data`.
Patch Set #1, Line 343: static struct spi_master spi_master_pickit2 = {
This will bug me with every single patch. I think the API is just broken
and maybe we should fix it before making more use of it. The per-instance
`data` pointer should simply be passed to register_spi_master(), IMHO.
This might actually be easier to address right now as there are not that
many programmer drivers that use the `data` pointer yet.
Patch Set #1, Line 472: pickit2_data = calloc(1, sizeof(*pickit2_data));
No NULL check? (Could be avoided by not using a struct.)
To view, visit change 52774. To unsubscribe, or for help writing mail filters, visit settings.