Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer.
View Change
1 comment:
Patchset:
Patch Set #1:
Kankan, thank you for your patch, appreciate adding support for so many chip models!
I have few questions:
1) Could you please split your commit into smaller ones? It can be one model per commit, also can be a group of models if they are related. And then smaller commits can be reviewed and finished one by one.
2) Do you have links to datasheets?
3) I noticed that test status for the models in this patch is different, some of them are tested, some are not. Does the status corresponds to what you were testing?
Thanks!
To view, visit change 83089. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I4e4eec6553407466b4b84969a806f046f6bddcbf
Gerrit-Change-Number: 83089
Gerrit-PatchSet: 1
Gerrit-Owner: Ssunk <ssunkkan@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Attention: Ssunk <ssunkkan@gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Sun, 16 Jun 2024 08:41:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No