Felix Singer submitted this change.

View Change


Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved
dediprog: Fix segmentation fault on no device found

libusb_exit() call is done by dediprog_open() under the
ret == 1 condition. Removing this line has no impact on
any flow and side effect of the program.

Change-Id: I38b3f3ee3f9d46845df1404791f4a4782320aa7c
Signed-off-by: Medicine Yeh <medicinehy@gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/48688
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67869
Reviewed-by: Felix Singer <felixsinger@posteo.net>
---
M dediprog.c
1 file changed, 21 insertions(+), 1 deletion(-)

diff --git a/dediprog.c b/dediprog.c
index 175e099..99df7b0 100644
--- a/dediprog.c
+++ b/dediprog.c
@@ -1188,7 +1188,6 @@
ret = dediprog_open(i);
if (ret == -1) {
/* no dev */
- libusb_exit(usb_ctx);
return 1;
} else if (ret == -2) {
/* busy dev */

To view, visit change 67869. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: 1.2.x
Gerrit-Change-Id: I38b3f3ee3f9d46845df1404791f4a4782320aa7c
Gerrit-Change-Number: 67869
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Medicine Yeh <medicinehy@gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged