Attention is currently required from: Edward O'Callaghan, Tom Hughes.
3 comments:
Commit Message:
The nested "struct tested" struct is "struct flashchip::tested" in C++.
Move "struct tested" to the top level namespace to avoid this
difference when using the "TEST_" macros that cast to "struct tested".
If you could be more specific on what exactly the problem this patch is solving? What does it mean "to avoid this difference"?
Patch Set #1, Line 14: TEST=emerge-hatch flashrom
You need to add info how you tested in upstream tree (emerge-hatch is not upstream). For example, did you build with make? did you run unit tests?
File flash.h:
Patch Set #1, Line 157: Indicate how well flashrom supports different operations of this flash chip.
This comment now duplicates for struct type and below. I think it is fine to leave it below (where it was originally).
But here, you need a different comment: describe what enum means?
To view, visit change 62999. To unsubscribe, or for help writing mail filters, visit settings.