Attention is currently required from: Raul Rangel, Jon Murphy, Karthik Ramasubramanian, Felix Held.
3 comments:
Commit Message:
Flashrom has been using legacy spi100 bit mappings when programming the
opcode and triggering the command. These legacy bit mappings are
deprecated in upcoming generation of AMD SoCs.
The knowledge of how SPI100 works completely is spare, can you provide more precise details here?
Stop using the legacy
spi100 registers and use the correct ones.
Is this backwards compatiable with all chipsets that find their way onto these specific branches of `spi100_spi_send_command()`?
Can you test the earlier chipsets to ensure we do not regress them?
File sb600spi.c:
Patch Set #1, Line 574: promontory_read_memmapped(
does this patch allow for this hack to be removed?
It would be useful to know precisely why this was needed on newer AMD spi controllers to make it work^tm?
The following maybe co-related:
https://review.coreboot.org/c/flashrom/+/58776
https://review.coreboot.org/c/flashrom/+/58777
but need some attention and coordination of a board owner.
To view, visit change 63422. To unsubscribe, or for help writing mail filters, visit settings.